fix(harness): preserve explicit sandbox snapshot specs#2363
Open
March-77 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
March-77
marked this pull request as ready for review
July 23, 2026 03:36
Collaborator
|
CLA Not Signed The Contributor License Agreement (CLA) check is currently pending on this PR ( @March-77 please sign the CLA via the CLA assistant badge in the comment above, or visit https://cla-assistant.io/agentscope-ai/agentscope-java. Once signed, the Automated check by github-manager-bot |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.0.1-SNAPSHOT
Description
Background
Filesystem-specific
snapshotSpec(...)overrides stored the value only in each subclass. The baseSandboxFilesystemSpec.snapshotSpecOverridetherefore remained null, allowingHarnessAgentto replace an explicit filesystem snapshot configuration with theDistributedStoredefault.Changes
LocalSnapshotSpectakes precedence over a distributed store'sNoopSnapshotSpec.Fixes #2254
Testing
Passed:
The four extension modules now pass 52 tests in total (24 Kubernetes, 17 AgentRun, 1 Daytona, and 10 E2B).
A full
agentscope-harnessmodule test run executed 649 tests with 0 assertion failures, but Maven reported 5 unrelated Windows JUnit temporary-directory cleanup errors (DirectoryNotEmptyException).Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)